api-ombi.go

@@ -4,7 +4,6 @@ import (
 	"fmt"
 
 	"github.com/gin-gonic/gin"
-	"github.com/hrfee/mediabrowser"
 )
 
 func (app *appContext) getOmbiUser(jfID string) (map[string]interface{}, int, error) {
@@ -30,31 +29,7 @@ func (app *appContext) getOmbiUser(jfID string) (map[string]interface{}, int, er
 			return ombiUser, code, err
 		}
 	}
-	return nil, 400, fmt.Errorf("couldn't find user")
+	return nil, 400, fmt.Errorf("Couldn't find user")
-}
-
-// Returns a user with the given name who has been imported from Jellyfin/Emby by Ombi
-func (app *appContext) getOmbiImportedUser(name string) (map[string]interface{}, int, error) {
-	// Ombi User Types: 3/4 = Emby, 5 = Jellyfin
-	ombiUsers, code, err := app.ombi.GetUsers()
-	if err != nil || code != 200 {
-		return nil, code, err
-	}
-	for _, ombiUser := range ombiUsers {
-		if ombiUser["userName"].(string) == name {
-			uType, ok := ombiUser["userType"].(int)
-			if !ok { // Don't know if Ombi somehow allows duplicate usernames
-				continue
-			}
-			if serverType == mediabrowser.JellyfinServer && uType != 5 { // Jellyfin
-				continue
-			} else if uType != 3 && uType != 4 { // Emby
-				continue
-			}
-			return ombiUser, code, err
-		}
-	}
-	return nil, 400, fmt.Errorf("couldn't find user")
 }
 
 // @Summary Get a list of Ombi users.
@@ -132,18 +107,3 @@ func (app *appContext) DeleteOmbiProfile(gc *gin.Context) {
 	app.storage.SetProfileKey(profileName, profile)
 	respondBool(204, true, gc)
 }
-
-func (app *appContext) applyOmbiProfile(user map[string]interface{}, profile map[string]interface{}) (status int, err error) {
-	for k, v := range profile {
-		switch v.(type) {
-		case map[string]interface{}, []interface{}:
-			user[k] = v
-		default:
-			if v != user[k] {
-				user[k] = v
-			}
-		}
-	}
-	status, err = app.ombi.ModifyUser(user)
-	return
-}

api-users.go

@@ -377,47 +377,30 @@ func (app *appContext) newUser(req newUserDTO, confirmed bool) (f errorFunc, suc
 		if profile.Ombi != nil && len(profile.Ombi) != 0 {
 			template := profile.Ombi
 			errors, code, err := app.ombi.NewUser(req.Username, req.Password, req.Email, template)
-			accountExists := false
-			var ombiUser map[string]interface{}
 			if err != nil || code != 200 {
-				// Check if on the off chance, Ombi's user importer has already added the account.
+				app.info.Printf("Failed to create Ombi user (%d): %s", code, err)
-				ombiUser, status, err = app.getOmbiImportedUser(req.Username)
+				app.debug.Printf("Errors reported by Ombi: %s", strings.Join(errors, ", "))
-				if status == 200 && err == nil {
-					app.info.Println("Found existing Ombi user, applying changes")
-					accountExists = true
-					template["password"] = req.Password
-					status, err = app.applyOmbiProfile(ombiUser, template)
-					if status != 200 || err != nil {
-						app.err.Printf("Failed to modify existing Ombi user (%d): %v\n", status, err)
-					}
-				} else {
-					app.info.Printf("Failed to create Ombi user (%d): %s", code, err)
-					app.debug.Printf("Errors reported by Ombi: %s", strings.Join(errors, ", "))
-				}
 			} else {
-				ombiUser, status, err = app.getOmbiUser(id)
+				app.info.Println("Created Ombi user")
-				if status != 200 || err != nil {
-					app.err.Printf("Failed to get Ombi user (%d): %v", status, err)
-				} else {
-					app.info.Println("Created Ombi user")
-					accountExists = true
-				}
-			}
-			if accountExists {
 				if discordVerified || telegramVerified {
-					dID := ""
+					ombiUser, status, err := app.getOmbiUser(id)
-					tUser := ""
+					if status != 200 || err != nil {
-					if discordVerified {
+						app.err.Printf("Failed to get Ombi user (%d): %v", status, err)
-						dID = discordUser.ID
+					} else {
-					}
+						dID := ""
-					if telegramVerified {
+						tUser := ""
-						u, _ := app.storage.GetTelegramKey(user.ID)
+						if discordVerified {
-						tUser = u.Username
+							dID = discordUser.ID
-					}
+						}
-					resp, status, err := app.ombi.SetNotificationPrefs(ombiUser, dID, tUser)
+						if telegramVerified {
-					if !(status == 200 || status == 204) || err != nil {
+							u, _ := app.storage.GetTelegramKey(user.ID)
-						app.err.Printf("Failed to link Telegram/Discord to Ombi (%d): %v", status, err)
+							tUser = u.Username
-						app.debug.Printf("Response: %v", resp)
+						}
+						resp, status, err := app.ombi.SetNotificationPrefs(ombiUser, dID, tUser)
+						if !(status == 200 || status == 204) || err != nil {
+							app.err.Printf("Failed to link Telegram/Discord to Ombi (%d): %v", status, err)
+							app.debug.Printf("Response: %v", resp)
+						}
 					}
 				}
 			}
@@ -1231,7 +1214,17 @@ func (app *appContext) ApplySettings(gc *gin.Context) {
 				// newUser["userName"] = user["userName"]
 				// newUser["alias"] = user["alias"]
 				// newUser["emailAddress"] = user["emailAddress"]
-				status, err = app.applyOmbiProfile(user, ombi)
+				for k, v := range ombi {
+					switch v.(type) {
+					case map[string]interface{}, []interface{}:
+						user[k] = v
+					default:
+						if v != user[k] {
+							user[k] = v
+						}
+					}
+				}
+				status, err = app.ombi.ModifyUser(user)
 				if status != 200 || err != nil {
 					errorString += fmt.Sprintf("Apply %d: %v ", status, err)
 				}

api.go

@@ -182,7 +182,7 @@ func (app *appContext) ResetSetPassword(gc *gin.Context) {
 	}
 	if app.config.Section("ombi").Key("enabled").MustBool(false) {
 		// Silently fail for changing ombi passwords
-		if (status != 200 && status != 204) || err != nil {
+		if status != 200 || err != nil {
 			app.err.Printf("Failed to get user \"%s\" from jellyfin/emby (%d): %v", username, status, err)
 			respondBool(200, true, gc)
 			return