api-activities.go

@@ -86,7 +86,7 @@ func activitySourceToString(v ActivitySource) string {
 	return "anon"
 }
 
-// @Summary Get the requested set of activities, Paginated, filtered and sorted. Is a POST because of some issues I was having, ideally should be a GET.
+// @Summary Get the requested set of activities, Paginated, filtered and sorted.
 // @Produce json
 // @Param GetActivitiesDTO body GetActivitiesDTO true "search parameters"
 // @Success 200 {object} GetActivitiesRespDTO

api-invites.go

@@ -11,6 +11,7 @@ import (
 	lm "github.com/hrfee/jfa-go/logmessages"
 	"github.com/itchyny/timefmt-go"
 	"github.com/lithammer/shortuuid/v3"
+	"github.com/timshannon/badgerhold/v4"
 )
 
 const (
@@ -331,8 +332,23 @@ func (app *appContext) GetInvites(gc *gin.Context) {
 		}
 		invites = append(invites, invite)
 	}
+	fullProfileList := app.storage.GetProfiles()
+	profiles := make([]string, len(fullProfileList))
+	if len(profiles) != 0 {
+		defaultProfile := app.storage.GetDefaultProfile()
+		profiles[0] = defaultProfile.Name
+		i := 1
+		if len(fullProfileList) > 1 {
+			app.storage.db.ForEach(badgerhold.Where("Name").Ne(profiles[0]), func(p *Profile) error {
+				profiles[i] = p.Name
+				i++
+				return nil
+			})
+		}
+	}
 	resp := getInvitesDTO{
-		Invites: invites,
+		Profiles: profiles,
+		Invites:  invites,
 	}
 	gc.JSON(200, resp)
 }
@@ -344,7 +360,7 @@ func (app *appContext) GetInvites(gc *gin.Context) {
 // @Failure 500 {object} stringResponse
 // @Router /invites/profile [post]
 // @Security Bearer
-// @tags Invites
+// @tags Profiles & Settings
 func (app *appContext) SetProfile(gc *gin.Context) {
 	var req inviteProfileDTO
 	gc.BindJSON(&req)

api-profiles.go

@@ -9,34 +9,7 @@ import (
 	"github.com/timshannon/badgerhold/v4"
 )
 
-// @Summary Get the names of all available profile.
-// @Produce json
-// @Success 200 {object} getProfileNamesDTO
-// @Router /profiles/names [get]
-// @Security Bearer
-// @tags Profiles & Settings
-func (app *appContext) GetProfileNames(gc *gin.Context) {
-	fullProfileList := app.storage.GetProfiles()
-	profiles := make([]string, len(fullProfileList))
-	if len(profiles) != 0 {
-		defaultProfile := app.storage.GetDefaultProfile()
-		profiles[0] = defaultProfile.Name
-		i := 1
-		if len(fullProfileList) > 1 {
-			app.storage.db.ForEach(badgerhold.Where("Name").Ne(profiles[0]), func(p *Profile) error {
-				profiles[i] = p.Name
-				i++
-				return nil
-			})
-		}
-	}
-	resp := getProfileNamesDTO{
-		Profiles: profiles,
-	}
-	gc.JSON(200, resp)
-}
-
-// @Summary Get all available profiles, indexed by their names.
+// @Summary Get a list of profiles
 // @Produce json
 // @Success 200 {object} getProfilesDTO
 // @Router /profiles [get]

api-users.go

@@ -20,7 +20,7 @@ import (
 // @Produce json
 // @Param newUserDTO body newUserDTO true "New user request object"
 // @Success 200
-// @Router /user [post]
+// @Router /users [post]
 // @Security Bearer
 // @tags Users
 func (app *appContext) NewUserFromAdmin(gc *gin.Context) {
@@ -68,7 +68,7 @@ func (app *appContext) NewUserFromAdmin(gc *gin.Context) {
 // @Param newUserDTO body newUserDTO true "New user request object"
 // @Success 200 {object} PasswordValidation
 // @Failure 400 {object} PasswordValidation
-// @Router /user/invite [post]
+// @Router /newUser [post]
 // @tags Users
 func (app *appContext) NewUserFromInvite(gc *gin.Context) {
 	/*
@@ -709,7 +709,7 @@ func (app *appContext) SaveAnnounceTemplate(gc *gin.Context) {
 	respondBool(200, true, gc)
 }
 
-// @Summary Gets the names of each available announcement template.
+// @Summary Save an announcement as a template for use or editing later.
 // @Produce json
 // @Success 200 {object} getAnnouncementsDTO
 // @Router /users/announce [get]

css/base.css

@@ -18,8 +18,6 @@
 
     --bg-light: #fff;
     --bg-dark: #101010;
-
-    color-scheme: light;
 }
 
 .light {
@@ -28,7 +26,6 @@
 
 .dark {
     --settings-section-button-filter: 80%;
-    color-scheme: dark !important;
 }
 
 .dark body {
@@ -459,14 +456,3 @@ input[type="checkbox" i], [class^="ri-"], [class*=" ri-"], .ri-refresh-line:befo
     margin-bottom: -0.5rem;
     padding-bottom: 0.5rem;
 }
-
-section.section:not(.\~neutral) {
-    background-color: inherit;
-}
-
-@layer components {
-    .switch input {
-        @apply mr-1;
-    }
-}
-

lang/setup/en-us.json

@@ -102,7 +102,6 @@
     "jellyseerr": {
         "title": "Jellyseerr",
         "description": "Jellyseerr is an alternative to Ombi, and integrates with jfa-go slightly better. Again, after setup is finished, go to Settings to create a profile and add a template for new Jellyseerr accounts.",
-        "importExisting": "Import existing users",
         "importExistingDescription": "If enabled, your existing users will have contact details and preferences from jfa-go synchronized."
     },
     "messages": {
@@ -165,7 +164,6 @@
     "helpMessages": {
         "title": "Help Messages",
         "description": "These messages will display in the account creation page and in some emails.",
-        "markdownMessageNotice": "Contents of some emails, pages and messages can be customized further with markdown in Settings.",
         "contactMessage": "Contact Message",
         "contactMessageNotice": "Displays at the bottom of all pages except admin.",
         "helpMessage": "Help Message",

models.go

@@ -88,10 +88,6 @@ type getProfilesDTO struct {
 	DefaultProfile string                `json:"default_profile"`
 }
 
-type getProfileNamesDTO struct {
-	Profiles []string `json:"profiles"` // List of profiles (name only)
-}
-
 type profileChangeDTO struct {
 	Name string `json:"name" example:"DefaultProfile" binding:"required"` // Name of the profile
 }
@@ -127,7 +123,8 @@ type inviteDTO struct {
 }
 
 type getInvitesDTO struct {
-	Invites []inviteDTO `json:"invites"` // List of invites
+	Profiles []string    `json:"profiles"` // List of profiles (name only)
+	Invites  []inviteDTO `json:"invites"`  // List of invites
 }
 
 // fake DTO, if i actually used this the code would be a lot longer

router.go

@@ -135,7 +135,7 @@ func (app *appContext) loadRoutes(router *gin.Engine) {
 		router.GET(p+"/lang/:page/:file", app.ServeLang)
 		router.GET(p+"/token/login", app.getTokenLogin)
 		router.GET(p+"/token/refresh", app.getTokenRefresh)
-		router.POST(p+"/user/invite", app.NewUserFromInvite)
+		router.POST(p+"/newUser", app.NewUserFromInvite)
 		router.Use(static.Serve(p+"/invite/", app.webFS))
 		router.GET(p+"/invite/:invCode", app.InviteProxy)
 		if app.config.Section("captcha").Key("enabled").MustBool(false) {
@@ -182,7 +182,7 @@ func (app *appContext) loadRoutes(router *gin.Engine) {
 		router.POST(p+"/logout", app.Logout)
 		api.DELETE(p+"/users", app.DeleteUsers)
 		api.GET(p+"/users", app.GetUsers)
-		api.POST(p+"/user", app.NewUserFromAdmin)
+		api.POST(p+"/users", app.NewUserFromAdmin)
 		api.POST(p+"/users/extend", app.ExtendExpiry)
 		api.DELETE(p+"/users/:id/expiry", app.RemoveExpiry)
 		api.POST(p+"/users/enable", app.EnableDisableUsers)
@@ -191,7 +191,6 @@ func (app *appContext) loadRoutes(router *gin.Engine) {
 		api.DELETE(p+"/invites", app.DeleteInvite)
 		api.POST(p+"/invites/profile", app.SetProfile)
 		api.GET(p+"/profiles", app.GetProfiles)
-		api.GET(p+"/profiles/names", app.GetProfileNames)
 		api.POST(p+"/profiles/default", app.SetDefaultProfile)
 		api.POST(p+"/profiles", app.CreateProfile)
 		api.DELETE(p+"/profiles", app.DeleteProfile)

scripts/missing-colors.js

@@ -33,7 +33,7 @@ function fixHTML(infile, outfile) {
         }
     }
     let doc = new parser.load(f);
-    for (let item of ["badge", "chip", "shield", "input", "table", "button", "portal", "select", "aside", "card", "field", "textarea", "section"]) {
+    for (let item of ["badge", "chip", "shield", "input", "table", "button", "portal", "select", "aside", "card", "field", "textarea"]) {
         let items = doc("."+item);
         items.each((i, elem) => {
             let hasColor = false;
@@ -50,8 +50,8 @@ function fixHTML(infile, outfile) {
             }
             if (!hasColor) {
                 if (!hasDark(doc(elem))) {
-                    // card (and sections in sectioned cards) without ~neutral look different than with.
-                    if (item != "card" && item != "section") doc(elem).addClass("~neutral");
+                    // card without ~neutral look different than with.
+                    if (item != "card") doc(elem).addClass("~neutral");
                     doc(elem).addClass("dark:~d_neutral");
                 }
             }

ts/admin.ts

@@ -6,7 +6,7 @@ import { inviteList, createInvite } from "./modules/invites.js";
 import { accountsList } from "./modules/accounts.js";
 import { settingsList } from "./modules/settings.js";
 import { activityList } from "./modules/activity.js";
-import { ProfileEditor, reloadProfileNames } from "./modules/profiles.js";
+import { ProfileEditor } from "./modules/profiles.js";
 import { _get, _post, notificationBox, whichAnimationEvent, bindManualDropdowns } from "./modules/common.js";
 import { Updater } from "./modules/update.js";
 import { Login } from "./modules/login.js";
@@ -187,7 +187,7 @@ login.onLogin = () => {
     console.log("Logged in.");
     window.updater = new Updater();
     // FIXME: Decide whether to autoload activity or not
-    reloadProfileNames();
+    window.invites.reload()
     setInterval(() => { window.invites.reload(); accounts.reload(); }, 30*1000);
     const currentTab = window.tabs.current;
     switch (currentTab) {

ts/form.ts

@@ -289,7 +289,7 @@ const create = (event: SubmitEvent) => {
             send.captcha_text = captcha.input.value;
         }
     }
-    _post("/user/invite", send, (req: XMLHttpRequest) => {
+    _post("/newUser", send, (req: XMLHttpRequest) => {
         if (req.readyState != 4) return;
         removeLoader(submitSpan);
         let vals = req.response as ValidatorRespDTO;

ts/modules/accounts.ts

@@ -1128,7 +1128,7 @@ export class accountsList {
             }
         }
         toggleLoader(button);
-        _post("/user", send, (req: XMLHttpRequest) => {
+        _post("/users", send, (req: XMLHttpRequest) => {
             if (req.readyState == 4) {
                 toggleLoader(button);
                 if (req.status == 200 || (req.response["user"] as boolean)) {

ts/modules/invites.ts

@@ -1,6 +1,5 @@
 import { _get, _post, _delete, toClipboard, toggleLoader, toDateString } from "../modules/common.js";
 import { DiscordUser, newDiscordSearch } from "../modules/discord.js";
-import { reloadProfileNames }  from "../modules/profiles.js";
 
 class DOMInvite implements Invite {
     updateNotify = (checkbox: HTMLInputElement) => {
@@ -432,6 +431,7 @@ export class inviteList implements inviteList {
     private _list: HTMLDivElement;
     private _empty: boolean;
     // since invite reload sends profiles, this event it broadcast so the createInvite object can load them.
+    private _profileLoadEvent = new CustomEvent("profileLoadEvent");
 
     invites: { [code: string]: DOMInvite };
 
@@ -502,9 +502,13 @@ export class inviteList implements inviteList {
         this._list.appendChild(domInv.asElement());
     }
 
-    reload = (callback?: () => void) => reloadProfileNames(() => _get("/invites", null, (req: XMLHttpRequest) => {
+    reload = (callback?: () => void) => _get("/invites", null, (req: XMLHttpRequest) => {
         if (req.readyState == 4) {
             let data = req.response;
+            if (req.status == 200) {
+                window.availableProfiles = data["profiles"];
+                document.dispatchEvent(this._profileLoadEvent);
+            }
             if (data["invites"] === undefined || data["invites"] == null || data["invites"].length == 0) {
                 this.empty = true;
                 return;
@@ -530,7 +534,7 @@ export class inviteList implements inviteList {
 
             if (callback) callback();
         }
-    }));
+    })
 }
 
 export const inviteURLEvent = (id: string) => { return new CustomEvent(inviteList._inviteURLEvent, {"detail": id}) };

ts/modules/profiles.ts

@@ -1,13 +1,5 @@
 import { _get, _post, _delete, toggleLoader } from "../modules/common.js";
 
-export const profileLoadEvent = new CustomEvent("profileLoadEvent");
-export const reloadProfileNames = (then?: () => void) => _get("/profiles/names", null, (req: XMLHttpRequest) => {
-    if (req.readyState != 4) return;
-    window.availableProfiles = req.response["profiles"];
-    document.dispatchEvent(profileLoadEvent);
-    if (then) then();
-});
-
 interface Profile {
     admin: boolean;
     libraries: string;

ts/modules/theme.ts

@@ -1,7 +1,6 @@
 export class ThemeManager {
 
     private _themeButton: HTMLElement = null;
-    private _metaTag: HTMLMetaElement;
     
     private _beforeTransition = () => {
         const doc = document.documentElement;
@@ -46,7 +45,6 @@ export class ThemeManager {
     }
 
     constructor(button?: HTMLElement) {
-        this._metaTag = document.querySelector("meta[name=color-scheme]") as HTMLMetaElement;
         const theme = localStorage.getItem("theme");
         if (theme == "dark") {
             this._enable(true);
@@ -56,22 +54,18 @@ export class ThemeManager {
             this._enable(true);
         }
 
-        if (button)
+        if (arguments.length == 1)
             this.bindButton(button);
     }
 
     private _toggle = () => {
-        let metaValue = "light dark";
         this._beforeTransition();
         if (!document.documentElement.classList.contains('dark')) {
             document.documentElement.classList.add('dark');
-            metaValue = "dark light";
         } else {
             document.documentElement.classList.remove('dark');
         }
         localStorage.setItem('theme', document.documentElement.classList.contains('dark') ? "dark" : "light");
-        
-        // this._metaTag.setAttribute("content", metaValue);
     };
 
     private _enable = (dark: boolean) => {
@@ -86,8 +80,6 @@ export class ThemeManager {
             document.documentElement.classList.remove(opposite);
         }
         document.documentElement.classList.add(mode);
-
-        // this._metaTag.setAttribute("content", `${mode} ${opposite}`);
     };
 
     enable = (dark: boolean) => {

ts/setup.ts

@@ -1,6 +1,5 @@
 import { _get, _post, toggleLoader, notificationBox } from "./modules/common.js";
 import { lang, LangFile, loadLangSelector } from "./modules/lang.js";
-import { ThemeManager } from "./modules/theme.js";
 
 interface sWindow extends Window {
     messages: {};
@@ -9,7 +8,6 @@ interface sWindow extends Window {
 declare var window: sWindow;
 window.URLBase = "";
 
-const theme = new ThemeManager(document.getElementById("button-theme"));
 
 window.notifications = new notificationBox(document.getElementById('notification-box') as HTMLDivElement, 5);
 
@@ -70,16 +68,7 @@ class Checkbox {
     constructor(el: HTMLElement, depends?: string, dependsTrue?: boolean, section?: string, setting?: string) {
         this._el = el as HTMLInputElement;
         this._hideEl = this._el as HTMLElement;
-        if (this._hideEl.parentElement.tagName == "LABEL") {
-            this._hideEl = this._hideEl.parentElement;
-        } else if (this._hideEl.parentElement.classList.contains("switch")) {
-            if (this._hideEl.parentElement.parentElement.tagName == "LABEL") {
-                this._hideEl = this._hideEl.parentElement.parentElement;
-            } else {
-                this._hideEl = this._hideEl.parentElement;
-            }
-        }
-
+        if (this._hideEl.parentElement.tagName == "LABEL") { this._hideEl = this._hideEl.parentElement; }
         if (section && setting) {
             this._section = section;
             this._setting = setting;
@@ -97,11 +86,11 @@ class Checkbox {
             });
         }
 
-        /* if (this._el.hasAttribute("checked")) {
+        if (this._el.hasAttribute("checked")) {
             this._el.checked = true;
         } else {
             this._el.checked = false;
-        } */
+        }
         this.broadcast();
     }
 }
@@ -228,7 +217,7 @@ class LangSelect extends Select {
                 }
                 this.value = "en-us";
             }
-        }, true);
+        });
     }
 }
 
@@ -459,32 +448,23 @@ settings["email"]["method"].onchange = emailMethodChange;
 settings["messages"]["enabled"].onchange = emailMethodChange;
 emailMethodChange();
 
-const getParentCard = (el: HTMLElement): HTMLDivElement => {
-    let pEl = el.parentElement;
-    while (pEl.tagName != "html") {
-        if (pEl.classList.contains("card")) return pEl as HTMLDivElement;
-        pEl = pEl.parentElement;
-    }
-    return pEl as HTMLDivElement;
-};
-
 const jellyfinLoginAccessChange = () => {
     const adminOnly = settings["ui"]["admin_only"].value == "true";
     const allowAll  = settings["ui"]["allow_all"].value == "true";
     const adminOnlyEl = document.getElementById("ui-admin_only") as HTMLInputElement;
-    const allowAllEl = document.getElementById("ui-allow_all") as HTMLInputElement;
-    const nextButton = getParentCard(adminOnlyEl).querySelector("span.next") as HTMLSpanElement;
+    const allowAllEls = [document.getElementById("ui-allow_all"), document.getElementById("description-ui-allow_all")];
+    const nextButton = adminOnlyEl.parentElement.parentElement.parentElement.querySelector("span.next") as HTMLSpanElement;
     if (adminOnly && !allowAll) {
-        allowAllEl.disabled = true;
+        (allowAllEls[0] as HTMLInputElement).disabled = true;
         adminOnlyEl.disabled = false;
         nextButton.removeAttribute("disabled");
     } else if (!adminOnly && allowAll) {
         adminOnlyEl.disabled = true;
-        allowAllEl.disabled = false;
+        (allowAllEls[0] as HTMLInputElement).disabled = false;
         nextButton.removeAttribute("disabled");
     } else { 
         adminOnlyEl.disabled = false;
-        allowAllEl.disabled = false;
+        (allowAllEls[0] as HTMLInputElement).disabled = false;
         nextButton.setAttribute("disabled", "true")
     }
 };
@@ -515,17 +495,18 @@ for (let section in settings) {
 
 const pageNames: string[][] = [];
 
-(() => {
-    const pushState = window.history.pushState;
-    window.history.pushState = function (data: any, __: string, _: string | URL) {
-        pushState.apply(window.history, arguments);
-        let ev = { state: data as string } as PopStateEvent;
-        window.onpopstate(ev);
-    };
-})();
+window.history.replaceState("welcome", "Setup - jfa-go");
 
+const changePage = (title: string, pageTitle: string) => {
+    const urlParams = new URLSearchParams(window.location.search);
+    const lang = urlParams.get("lang");
+    let page = "/#" + title;
+    if (lang) { page += "?lang=" + lang; }
+    window.history.pushState(title || "welcome", pageTitle, page);
+};
+const cards = Array.from(document.getElementById("page-container").getElementsByClassName("card")) as Array<HTMLDivElement>;
+(window as any).cards = cards;
 window.onpopstate = (event: PopStateEvent) => {
-    console.log("CALLLLLLLL", event);
     if (event.state === "welcome") {
         cards[0].classList.remove("unfocused");
         for (let i = 1; i < cards.length; i++) { cards[i].classList.add("unfocused"); }
@@ -540,35 +521,6 @@ window.onpopstate = (event: PopStateEvent) => {
     }
 };
 
-const cards = Array.from(document.getElementsByClassName("page-container")[0].querySelectorAll(".card.sectioned")) as Array<HTMLDivElement>;
-(window as any).cards = cards;
-
-const changePageToIndex = (title: string, pageTitle: string, i: number) => {
-    cards[i].classList.remove("unfocused");
-    const urlParams = new URLSearchParams(window.location.search);
-    const lang = urlParams.get("lang");
-    let page = "/#" + title;
-    if (lang) { page += "?lang=" + lang; }
-    console.log("pushing", title, pageTitle, page);
-    window.history.pushState(title || "welcome", pageTitle, page);
-};
-
-const changePage = (title: string, pageTitle: string) => {
-    let found = false;
-    for (let i = 0; i < cards.length; i++) {
-        if (!found && pageNames[i][0] == title && !(cards[i].classList.contains("hidden"))) {
-            found = true;
-            changePageToIndex(title, pageTitle, i);
-        } else {
-            cards[i].classList.add("unfocused");
-        }
-    }
-    if (!found) {
-        changePageToIndex(title, pageTitle, 0);
-    }
-    window.scrollTo(0, 0);
-};
-
 (() => {
     for (let i = 0; i < cards.length; i++) {
         const card = cards[i];
@@ -582,34 +534,36 @@ const changePage = (title: string, pageTitle: string) => {
         let pageTitle = titleEl.textContent + " - jfa-go";
         pageNames.push([title, pageTitle]);
         if (back) { back.addEventListener("click", () => {
+            let found = false;
             for (let ind = cards.length - 1; ind >= 0; ind--) {
-                if (ind < i && !(cards[ind].classList.contains("hidden"))) {
+                cards[ind].classList.add("unfocused");
+                if (ind < i && !(cards[ind].classList.contains("hidden")) && !found) {
+                    cards[ind].classList.remove("unfocused");
                     changePage(pageNames[ind][0], pageNames[ind][1]);
-                    break;
+                    found = true;
                 }
             }
+            window.scrollTo(0, 0);
         }); }
         if (next) {
             const func = () => {
                 if (next.hasAttribute("disabled")) return;
+                let found = false;
                 for (let ind = 0; ind < cards.length; ind++) {
-                    if (ind > i && !(cards[ind].classList.contains("hidden"))) {
+                    cards[ind].classList.add("unfocused");
+                    if (ind > i && !(cards[ind].classList.contains("hidden")) && !found) {
+                        cards[ind].classList.remove("unfocused");
                         changePage(pageNames[ind][0], pageNames[ind][1]);
-                        break;
+                        found = true;
                     }
                 }
+                window.scrollTo(0, 0);
             };
             next.addEventListener("click", func)
         }
     }
 })();
 
-(() => {
-    let initialLocation = window.location.hash.replace("#", "") || "welcome";
-    changePage(initialLocation, "Setup - jfa-go");
-})();
-// window.history.replaceState("welcome", "Setup - jfa-go",);
-
 (() => {
     const button = document.getElementById("jellyfin-test-connection") as HTMLSpanElement;
     const ogText = button.textContent;